a11y + Lighthouse pass: skill listing + detail (SOL-8)#12
Open
VisionaireLabs wants to merge 1 commit into
Open
a11y + Lighthouse pass: skill listing + detail (SOL-8)#12VisionaireLabs wants to merge 1 commit into
VisionaireLabs wants to merge 1 commit into
Conversation
…ages The monochrome pass (665413c) reintroduced sub-AA grays the earlier a11y commit had fixed, and the browse filters were never programmatically labeled. - SkillCard / Leaderboard: replace #555/#444/#333/#666 body text with the AA-passing #a3a3a3 / #8a8a8a values (use literal hex, not var(--muted) — CSS custom props don't resolve in inline styles during the CSS-load window and fall back to the default link color). - SkillsBrowser: associate search/category/platform <label>s via htmlFor+id (fixes select-name), name the price radiogroup, add aria-label to the sort <select>, and aria-pressed/aria-label to the view-toggle buttons. - Footer: underline the inline "Visionaire Labs" links so they're distinguishable from surrounding text without relying on color (fixes link-in-text-block). Lighthouse (desktop, prod build): listing a11y 88→100, detail 92→100. Performance 100 and CLS 0 were already optimal (pages are static SSG). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Accessibility + Lighthouse pass on the skill listing (
/skills) and detail (/skills/[slug]) pages.The earlier a11y commit (
760fc59) had AA contrast; the later monochrome pass (665413c) reintroduced sub-AA grays, and the browse filters were never programmatically labeled.Fixes
SkillCard+Leaderboardbody/meta text moved off#555/#444/#333/#666(2.8–3.7:1) to AA-passing#a3a3a3(6.5:1) /#8a8a8a(5:1). Used literal hex rather thanvar(--muted)— custom properties live in external CSS and don't resolve in inline styles during the CSS-load window, falling back to the default link color (blue, 2.2:1).select-name): search, category, platform<label>s now associated viahtmlFor+id; price radios wrapped in a namedradiogroup; sort<select>given anaria-label; view-toggle buttons givenaria-pressed+aria-label.link-in-text-block: underlined the inline "Visionaire Labs" footer links so they're distinguishable without relying on color.Before → After (Lighthouse, desktop preset, production build)
/skills(listing)/skills/[slug](detail)Resolved audits:
color-contrast(549 nodes listing / 16 detail),select-name,link-in-text-block.Performance was already 100 and CLS already 0 — both pages are statically prerendered (SSG), so there was no perf/CLS regression to fix; the gap was purely accessibility. Best-practices 100.
Build + lint pass.
🤖 Generated with Claude Code